Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow Util Directory #6366

Closed
wants to merge 1 commit into from
Closed

Narrow Util Directory #6366

wants to merge 1 commit into from

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is a BC break.

Changelog

### Changed
- Narrow the API for classes declared under the `Sonata\AdminBundle\Util\` namespace.

I have applied PHPStan level 8 and Psalm level 2 when doing it and all of the errors related to the typehints are done.

@core23 core23 mentioned this pull request Sep 7, 2020
Merged
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet VincentLanglet mentioned this pull request Oct 4, 2020
Closed
29 tasks
@tambait tambait mentioned this pull request Oct 23, 2020
Merged
@VincentLanglet
Copy link
Member

Closing in favor of #6533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordisala1991 @SonataCI @VincentLanglet